Fix LeafContext.application Casting Failure
#235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantjbutler
commented
Oct 28, 2024
| @@ -21,7 +21,7 @@ extension Application { | |||
|
|
|||
| public var renderer: LeafRenderer { | |||
| var userInfo = self.userInfo | |||
| userInfo["application"] = self | |||
There was a problem hiding this comment.
This is the crux of the issue. self here is of type Application.Leaf, but we want to assign an instance of Application for this key.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 68.44% 68.82% +0.38%
==========================================
Files 5 5
Lines 263 263
==========================================
+ Hits 180 181 +1
+ Misses 83 82 -1
|
grantjbutler
added a commit
to supersonicbyte/swift-vite
that referenced
this pull request
Oct 28, 2024
See vapor/leaf#235 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.4.1
Fixes an issue where the wrong type would be set to the
applicationuserInfokey when accessing the renderer directly on theApplication(it would set a value ofApplication.Leaf, rather thanApplication, and then the casting would fail onLeafContext.application).